https://jira.astppbilling.org This file is an XML representation of an issue en-us 8.13.3 813003 14-01-2021 https://jira.astppbilling.org/browse/ASTPPCOM-54 ASTPP Community <p>Calls that are inbound via a provider should not get rated using the origination rates. These calls should only get rated via the DID table.</p> <p>Further more the CDR for inbound is inserting 2 records into the table and should only insert the CDR for the customer and not the provider.</p> <p>This is causing inaccurate reporting for the provider and customers.</p> ASTPPCOM-54

Inbound calls from provider should not be rated through origination rates

New Feature Done Done Samir Doshi fozzygo4 Fri, 12 Aug 2016 13:32:21 +0530 Thu, 1 Apr 2021 19:00:40 +0530 Thu, 1 Apr 2021 19:00:40 +0530 v3.5 0 0 <p>I have made the following changes in /html/fs/lib/astpp.cdr.php that prevents the outbound CDR entry being added to CDR of the provider when the call is inbound from provider. Please let me know if this makes sense.</p> <p>At line: 118</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">+ <span class="code-keyword">if</span>($account_type != 3) + { $query = <span class="code-quote">"INSERT INTO cdrs (uniqueid,accountid,type,callerid,callednum,billseconds,trunk_id,trunkip,callerip,disposition,callstart,debit,cost,provider_id,pricelist_id,package_id,pattern,notes,rate_cost,reseller_id,reseller_code,reseller_code_destination,reseller_cost,provider_code,provider_code_destination,provider_cost,provider_call_cost,call_direction,calltype,profile_start_stamp,answer_stamp,bridge_stamp,progress_stamp,progress_media_stamp,end_stamp,billmsec,answermsec,waitmsec,progress_mediamsec,flow_billmsec) values ($cdr_string)"</span>; $logger-&gt;log($query); $db-&gt;run($query); + } </pre> </div></div> <p>I have further modified the IF statement as follows:<br/> <tt>if($account_type == 0 &amp;&amp; $dataVariable<span class="error">&#91;&#39;provider_id&#39;&#93;</span> != 0)</tt></p> <p>This now works correctly on CDR reports. It does the following:</p> <ul class="alternate" type="square"> <li>If the call is inbound from provider, the CDR record is entered into the DB as 1 record for the customer.</li> <li>If the call is inbound from customer A to customer B using a DID, the same applies to the CDR record as above.</li> <li>No CDR record of outbound is sent to the DB if the call is a DID call.</li> </ul> <p>This now works well on the basis that one does not bill customer A to customer B. Not sure how one would implement that.</p> <p>Also I have noticed that the balance of customer A is effected with call charge even though it is a free DID call.</p> <p>After doing some further testing I have come to the following conclusion and some scenarios:</p> <p>I now understand the principle of the inbound call being rated through origination rates based on the fact that if a provider charges for inbound calls then you would want to pass that charge onto the customer. If not then you can simply add the DID to the origination rate and the call will not be billed but this still adds extra records to the CDR table which still makes the duration total inaccurate. The solution to this is to remove the extra DID entry from the CDR table but the record for the CDR from the provider will have a disposition of "STANDARD" and not DID. This also adds room for error if one adds a DID to a customer and forgets to add the DID to all the origination rates. So my conclusion is this is not practical.</p> <p>Another scenario and this is more practical but I feel needs extra work done on the DID rating system else it does not give the ability to have inbound charges calculated to the provider.<br/> As mentioned in the above posts I feel the inbound calls should not be rated through an origination rate and rather be rated through the DID entry.</p> <p>Currently you can add a per min charge and intervals to the DID but this will bill the customer who owns the DID. perhaps add a cost field to the DID for the provider or a checkbox to enable or disable billing of the provider.</p> <p>Hope this makes sense to everyone. At this point as we are not charging for inbound calls in my country, I have made the following changes the the astpp.cdr.php file that makes my scenario work for me.</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-comment">// *** Function by Fozzy *** </span> <span class="code-keyword">if</span>($account_type == 0 &amp;&amp; $dataVariable[<span class="code-quote">'provider_id'</span>] != 0) { $query = <span class="code-quote">"INSERT INTO cdrs (uniqueid,accountid,type,callerid,callednum,billseconds,trunk_id,trunkip,callerip,disposition,callstart,debit,cost,provider_id,pricelist_id,package_id,pattern,notes,rate_cost,reseller_id,reseller_code,reseller_code_destination,reseller_cost,provider_code,provider_code_destination,provider_cost,provider_call_cost,call_direction,calltype,profile_start_stamp,answer_stamp,bridge_stamp,progress_stamp,progress_media_stamp,end_stamp,billmsec,answermsec,waitmsec,progress_mediamsec,flow_billmsec) values ($cdr_string)"</span>; $logger-&gt;log($query); $db-&gt;run($query); } <span class="code-comment">// End Function by Foz </span> <span class="code-comment">//Update customer balance </span> <span class="code-comment">//<span class="code-keyword">if</span>($debit &gt; 0 &amp;&amp; $dataVariable[<span class="code-quote">'calltype'</span>] != <span class="code-quote">"FREE"</span>) </span> <span class="code-comment">// Function modified my Fozzy </span> <span class="code-keyword">if</span>($debit &gt; 0 &amp;&amp; $dataVariable[<span class="code-quote">'calltype'</span>] != <span class="code-quote">"FREE"</span> &amp;&amp; $account_type == 0 &amp;&amp; $dataVariable[<span class="code-quote">'provider_id'</span>] != 0) { update_balance($accountid, $debit, 0, $logger, $db); } </pre> </div></div> <p>We made it configurable. If you want to avoid it then you need to set variable INB_FREE="true" in /var/lib/astpp/astpp.lua. That will avoid billing of DID calls for provider. </p> <p>Update to ASTPP 3.5 and test it out. </p> <p>i have same issue as fuzzy, i need to know my COST from provider on the DID...</p> <p>right now inbound call never show any cost in /reports/customerReport/</p> <p>We do not have DID buy rate option at the moment. Becuase of that you will not be able to get any value in COST field in DID calls. </p> <p>If you want to know the cost for the provider then you can create origination rate with DID prefix and define the amount in that. Then assign that rate group to provider. So whenever, we will get call from that provider, system will check origination rates and then route the call to DID. </p> <p>That way you will get 2 entries. 1 with provider account with debit value and 2nd with customer to whom DID is assigned. </p> <p>Note: Make sure you do not have INB_FREE configured in astpp-config.lua. </p> <p>i did that put the full DID in the originator rate, i get this as cdr</p> <p><a href="http://prntscr.com/ipo08k" class="external-link" target="_blank" rel="nofollow noopener">http://prntscr.com/ipo08k</a></p> <p>and astpp logs</p> <p>`<br/> action application="set" data="fax_enable_t38_request=true"/&gt;<br/> &lt;action application="set" data="origination_rates_did=ID:5|CODE:^.1418xxxxxx.*|DESTINATION:1418xxxxxx|CONNECTIONCOST:0.00000|INCLUDEDSECONDS:0|COST:0.01875|INC:0|INITIALBLOCK:0|RATEGROUP:0|MARKUP:150|ACCID:5"/&gt;<br/> &lt;action application="set" data="origination_rates=ID:371167|CODE:^1418xxxxxx.*|DESTINATION:DID|CONNECTIONCOST:0.00000|INCLUDEDSECONDS:0|COST:0.0125|INC:6|INITIALBLOCK:6|RATEGROUP:1|MARKUP:150|ACCID:4"/&gt;`</p> <p>but doesnt show in cost still.. any other idea ?</p> <p>hard to figure my costs when all inbound shows no cost</p> <p>Again, for DID calls, you will never get cost field. Cost field will have<br/> value when call will be routed via any trunk / carrier. For inbound calls,<br/> we are not routing call via trunk / carrier, so that field will never get<br/> populated.</p> <p>&lt;<a href="https://mailtrack.io/" class="external-link" target="_blank" rel="nofollow noopener">https://mailtrack.io/</a>&gt; Sent with Mailtrack<br/> &lt;<a href="https://mailtrack.io?utm_source=gmail&amp;utm_medium=signature&amp;utm_campaign=signaturevirality&amp;" class="external-link" target="_blank" rel="nofollow noopener">https://mailtrack.io?utm_source=gmail&amp;utm_medium=signature&amp;utm_campaign=signaturevirality&amp;</a>&gt;</p> <h2><a name="BestRegards"></a>Best Regards</h2> <p>Samir Doshi<br/> <em>iNextrix Technologie</em><em>s Pvt. Ltd</em>.<br/> <a href="http://www.inextrix.com" class="external-link" target="_blank" rel="nofollow noopener">http://www.inextrix.com</a></p> <p><em>Disclaimer:</em><br/> The information contained in this communication is confidential and may be<br/> legally privileged. It is intended solely for the use of the individual or<br/> entity to whom it is addressed and others authorized to receive it. If you<br/> are not the intended recipient you are hereby notified that any disclosure,<br/> copying, distribution or taking action in reliance on the contents of this<br/> information is strictly prohibited and may be unlawful. Please notify the<br/> sender immediately and destroy all copies of this message and any<br/> attachments contained in it.</p> <p>On Sun, Mar 11, 2018 at 6:57 PM, Frank &lt;notifications@github.com&gt; wrote:</p> <p>&gt; i did that put the full DID in the originator rate, i get this as cdr<br/> &gt;<br/> &gt; <a href="http://prntscr.com/ipo08k" class="external-link" target="_blank" rel="nofollow noopener">http://prntscr.com/ipo08k</a><br/> &gt;<br/> &gt; and astpp logs<br/> &gt;<br/> &gt; action application="set" data="fax_enable_t38_request=true"/&gt;<br/> &gt;<br/> &gt; but doesnt show in cost still.. any other idea ?<br/> &gt;<br/> &gt; hard to figure my costs when all inbound shows no cost<br/> &gt;<br/> &gt; —<br/> &gt; You are receiving this because you modified the open/close state.<br/> &gt; Reply to this email directly, view it on GitHub<br/> &gt; &lt;<a href="https://github.com/iNextrix/ASTPP/issues/54#issuecomment-372115550" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/iNextrix/ASTPP/issues/54#issuecomment-372115550</a>&gt;, or mute<br/> &gt; the thread<br/> &gt; &lt;<a href="https://github.com/notifications/unsubscribe-auth/AA6gcU4Kne2uRrvjBM2SVqZyaD5Q1SYkks5tdSZSgaJpZM4Ji29j" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/notifications/unsubscribe-auth/AA6gcU4Kne2uRrvjBM2SVqZyaD5Q1SYkks5tdSZSgaJpZM4Ji29j</a>&gt;<br/> &gt; .<br/> &gt;</p> <p>its a call from trunk..</p> <p>landline --&gt; telco --&gt; pri --&gt;provider SIP as 14185551212@astppIP (astpp) gets this from trunk provider aka gateway carrier etc</p> Development External issue ID 54 Rank 0|i008yv: