https://jira.astppbilling.org This file is an XML representation of an issue en-us 8.13.3 813003 14-01-2021 https://jira.astppbilling.org/browse/ASTPPCOM-401 ASTPP Community <p>It appears that deleting an account only makes the settings disappear from the GUI but not the DB. However, it is not just the row in the <tt>account</tt> table that remains but also associated settings in other tables. This creates problems when trying to add new settings as they will fail validation if they have the same SIP username or IP etc.</p> <p>There are probably other settings that are orphaned as well. Maybe all of them? Maybe this is by design and if so why?</p> ASTPPCOM-401

SIP devices and IP settings are orphaned after deleting provider account

New Feature Done Done Samir Doshi powerpbx bug_fixed Mon, 16 Apr 2018 01:30:48 +0530 Sun, 27 Oct 2019 15:49:59 +0530 Mon, 28 May 2018 12:53:20 +0530 0 0 <p>When you delete an account, we are deleting records from all modules which belong to that account except for accounts and cdrs. For account, we do soft delete which means only flag will be changed and it will disappear from the UI. </p> <p>The purpose to do soft delete of account and to keep CDR is, in many countries admin need to keep cdr records for all the customers for few months or years. Now if we hard delete those records then admin might be in trouble. To avoid that issue, we implemented soft delete concept. </p> <p>Now regarding your point for sip device and ip settings, I just tested it in version 3.6 and I am not facing any problem. I am able to create same sip device and ip settings. </p> <p>If you are still facing the problem then highlight the exact issue. </p> <p>This appears to happen on provider accounts but not customer accounts.</p> <p>To reproduce, create a provider account and add a sip device and IP settings. Note the sip device username and IP address. Now delete that provider account. The sip device and IP setting will still exist in the database but no longer shows up in the GUI. So it's orphaned data. This is not the the same behavior as customer accounts. Deleting a customer account from the GUI removes the respective devices and IP settings from the database.</p> <p>Now create a customer account or another provider account and a sip device with the exact same device username or IP settings with the same IP address as before. It will fail validation because that sip device username and IP setting still exists in the database as orphaned device and IP even though they are no longer in the GUI.</p> <p>Just tried same thing which you mentioned and it worked without any<br/> problem.</p> <p>Here is the video of it : <a href="http://nimb.ws/BqpSnb" class="external-link" target="_blank" rel="nofollow noopener">http://nimb.ws/BqpSnb</a></p> <p>‌<br/> <span class="error">&#91;image: Mailtrack&#93;</span><br/> &lt;<a href="https://mailtrack.io?utm_source=gmail&amp;utm_medium=signature&amp;utm_campaign=signaturevirality4&amp;" class="external-link" target="_blank" rel="nofollow noopener">https://mailtrack.io?utm_source=gmail&amp;utm_medium=signature&amp;utm_campaign=signaturevirality4&amp;</a>&gt;<br/> Sender<br/> notified by<br/> Mailtrack<br/> &lt;<a href="https://mailtrack.io?utm_source=gmail&amp;utm_medium=signature&amp;utm_campaign=signaturevirality4&amp;" class="external-link" target="_blank" rel="nofollow noopener">https://mailtrack.io?utm_source=gmail&amp;utm_medium=signature&amp;utm_campaign=signaturevirality4&amp;</a>&gt;</p> <h2><a name="BestRegards"></a>Best Regards</h2> <p>Samir Doshi<br/> <em>iNextrix Technologie</em><em>s Pvt. Ltd</em>.<br/> <a href="http://www.inextrix.com" class="external-link" target="_blank" rel="nofollow noopener">http://www.inextrix.com</a></p> <p><em>Disclaimer:</em><br/> The information contained in this communication is confidential and may be<br/> legally privileged. It is intended solely for the use of the individual or<br/> entity to whom it is addressed and others authorized to receive it. If you<br/> are not the intended recipient you are hereby notified that any disclosure,<br/> copying, distribution or taking action in reliance on the contents of this<br/> information is strictly prohibited and may be unlawful. Please notify the<br/> sender immediately and destroy all copies of this message and any<br/> attachments contained in it.</p> <p>On Thu, May 10, 2018 at 12:19 AM, powerpbx &lt;notifications@github.com&gt; wrote:</p> <p>&gt; Create a customer account and add a sip device. Now delete that customer<br/> &gt; account.<br/> &gt;<br/> &gt; Now create another customer account and try dd a sip device with the exact<br/> &gt; same name. It will fail validation because that same sip device name still<br/> &gt; exists in the database.<br/> &gt;<br/> &gt; I believe the same thing will happen if you add IP Settings to an account<br/> &gt; and then delete account and then try add the same IP again to a different<br/> &gt; account.<br/> &gt;<br/> &gt; —<br/> &gt; You are receiving this because you commented.<br/> &gt; Reply to this email directly, view it on GitHub<br/> &gt; &lt;<a href="https://github.com/iNextrix/ASTPP/issues/401#issuecomment-387838730" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/iNextrix/ASTPP/issues/401#issuecomment-387838730</a>&gt;, or mute<br/> &gt; the thread<br/> &gt; &lt;<a href="https://github.com/notifications/unsubscribe-auth/AA6gca17X9gGlZNXdduvqXwNERkPRbp1ks5twzowgaJpZM4TVn0j" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/notifications/unsubscribe-auth/AA6gca17X9gGlZNXdduvqXwNERkPRbp1ks5twzowgaJpZM4TVn0j</a>&gt;<br/> &gt; .<br/> &gt;</p> <p>That video shows you deleting a customer. Not a provider. The orphaned devices only occur when you delete providers with devices.</p> <p>This is the clean up function that is run for customer that does not exist for provider as far as I can tell. <br/> <a href="https://github.com/iNextrix/ASTPP/blob/4861cac21cd49153ecaa14573f89c1b04e5bcd38/web_interface/astpp/application/libraries/astpp/common.php#L2047" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/iNextrix/ASTPP/blob/4861cac21cd49153ecaa14573f89c1b04e5bcd38/web_interface/astpp/application/libraries/astpp/common.php#L2047</a></p> <p>It is run here<br/> <a href="https://github.com/iNextrix/ASTPP/blob/4861cac21cd49153ecaa14573f89c1b04e5bcd38/web_interface/astpp/application/libraries/astpp/common.php#L2098" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/iNextrix/ASTPP/blob/4861cac21cd49153ecaa14573f89c1b04e5bcd38/web_interface/astpp/application/libraries/astpp/common.php#L2098</a></p> <p>here<br/> <a href="https://github.com/iNextrix/ASTPP/blob/4861cac21cd49153ecaa14573f89c1b04e5bcd38/web_interface/astpp/application/modules/accounts/controllers/accounts.php#L2154" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/iNextrix/ASTPP/blob/4861cac21cd49153ecaa14573f89c1b04e5bcd38/web_interface/astpp/application/modules/accounts/controllers/accounts.php#L2154</a></p> <p>and here<br/> <a href="https://github.com/iNextrix/ASTPP/blob/4861cac21cd49153ecaa14573f89c1b04e5bcd38/web_interface/astpp/application/modules/accounts/controllers/accounts.php#L2340" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/iNextrix/ASTPP/blob/4861cac21cd49153ecaa14573f89c1b04e5bcd38/web_interface/astpp/application/modules/accounts/controllers/accounts.php#L2340</a></p> <p><span class="error">&#91;~powerpbx&#93;</span> Bug fixed.</p> Development External issue ID 401 Rank 0|i00b3z: