https://jira.astppbilling.org This file is an XML representation of an issue en-us 8.13.3 813003 14-01-2021 https://jira.astppbilling.org/browse/ASTPPCOM-36 ASTPP Community <p>Hi Team.</p> <p>I have modified and added my own code for DID management. I felt the need for ability to add call types of direct IP calling and a simpler version of the "OTHER" call type. I labeled them as Direct-IP and DID@IP/URL. See screenshot. Let me know how and if you would like me to share the code.</p> <p>The functions are as follows: <br/> Direct-IP uses the number of the DID @ the extension / destination field.<br/> DID@IP/URL is exactly like the "Other" option but it will just prepend sofia/default/&lt;destination&gt; field so you could use it to direct calls to any destination that is SIP URI capable.</p> <p>Examples:<br/> Direct-IP: DID field = 1235551234 and Destination field = 1.2.3.4<br/> The code behind will dial sofia/default/1235551234@1.2.3.4</p> <p>DID@IP/URL: DID field = 1235551234 and Destination field = 1234@1.2.3.4<br/> The code behind will dial sofia/default/1234@1.2.3.4</p> <p><span class="image-wrap" style=""><img src="https://cloud.githubusercontent.com/assets/20914943/17518402/1079c400-5e48-11e6-8852-4a0eb302433f.png" style="border: 0px solid black" /></span></p> ASTPPCOM-36

Contribute new code for DID call type management

New Feature Done Done Samir Doshi fozzygo4 contribution Tue, 9 Aug 2016 19:25:04 +0530 Sun, 27 Oct 2019 15:50:22 +0530 Tue, 5 Sep 2017 19:25:31 +0530 v3.5 0 0 <p>@FozzyGo4, Yeah it will be good if you contribute code. This will be helpful for people who usually doing call routing to IP only. </p> <p>Awesome so should I just post it here?</p> <p>Either you can send us the contribution in github as pull request <a href="https://guides.github.com/activities/contributing-to-open-source/" class="external-link" target="_blank" rel="nofollow noopener">https://guides.github.com/activities/contributing-to-open-source/</a> <br/> OR post the code with instruction. </p> <p>Ok im not sure how to do a pull request as I have never done so before so I will submit code here.</p> <p>Firstly in webUI /astpp/application/libraries/astpp/common.php</p> <p>Edit the code as follows:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> function set_call_type($call_type = "") { $call_type_array = array(<span class="code-quote">"-1"</span> =&gt; <span class="code-quote">"--Select--"</span>,<span class="code-quote">'1'</span> =&gt; <span class="code-quote">'DID-Local'</span>,<span class="code-quote">'3'</span>=&gt;<span class="code-quote">'SIP-DID'</span>,<span class="code-quote">'4'</span>=&gt;<span class="code-quote">'Direct-IP'</span>,<span class="code-quote">'5'</span>=&gt;<span class="code-quote">'DID@IP/URL'</span>, <span class="code-quote">'0'</span> =&gt; <span class="code-quote">'PSTN'</span>, <span class="code-quote">'2'</span> =&gt; <span class="code-quote">'Other'</span>,); <span class="code-keyword">return</span> $call_type_array; } function set_call_type_search(){ $call_type_array = array(<span class="code-quote">"" =&gt; "</span>--Select--",<span class="code-quote">'1'</span> =&gt; <span class="code-quote">'DID-Local'</span>,<span class="code-quote">'3'</span>=&gt;<span class="code-quote">'SIP-DID'</span>,<span class="code-quote">'4'</span>=&gt;<span class="code-quote">'Direct-IP'</span>,<span class="code-quote">'5'</span>=&gt;<span class="code-quote">'DID@IP/URL'</span>, <span class="code-quote">'0'</span> =&gt; <span class="code-quote">'PSTN'</span>, <span class="code-quote">'2'</span> =&gt; <span class="code-quote">'Other'</span>,); <span class="code-keyword">return</span> $call_type_array; } function get_call_type($select = <span class="code-quote">"", $table = "</span>", $call_type) { $call_type_array = array(<span class="code-quote">'1'</span> =&gt; <span class="code-quote">'DID-Local'</span>,<span class="code-quote">'3'</span>=&gt;<span class="code-quote">'SIP-DID'</span>,<span class="code-quote">'4'</span>=&gt;<span class="code-quote">'Direct-IP'</span>,<span class="code-quote">'5'</span>=&gt;<span class="code-quote">'DID@IP/URL'</span>,<span class="code-quote">'0'</span> =&gt; <span class="code-quote">'PSTN'</span>, <span class="code-quote">'2'</span> =&gt; <span class="code-quote">'Other'</span>,<span class="code-quote">'-1'</span>=&gt;""); <span class="code-keyword">return</span> $call_type_array[$call_type]; } function get_custom_call_type($call_type) { $call_type_array = array(<span class="code-quote">'DID-Local'</span> =&gt; <span class="code-quote">'1'</span>,<span class="code-quote">'SIP-DID'</span>=&gt;<span class="code-quote">'3'</span>,<span class="code-quote">'Direct-IP'</span>=&gt;<span class="code-quote">'4'</span>,<span class="code-quote">'DID@IP/URL'</span>=&gt;<span class="code-quote">'5'</span>,<span class="code-quote">'PSTN'</span> =&gt; <span class="code-quote">'0'</span>,<span class="code-quote">'Other'</span> =&gt; <span class="code-quote">'2'</span>,<span class="code-quote">""=&gt;"</span>-1"); <span class="code-keyword">return</span> $call_type_array[$call_type]; } </pre> </div></div> <p>This gives extra options for the dropdown menu.</p> <p>Then in /usr/local/freeswitch/scripts/astpp/scripts/astpp.xml.lua add the following under:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> elseif(tonumber(didinfo[<span class="code-quote">'call_type'</span>]) == 2 and didinfo[<span class="code-quote">'extensions'</span>] ~= '') then table.insert(xml, [[&lt;action application=<span class="code-quote">"set"</span> data=<span class="code-quote">"calltype=OTHER"</span>/&gt;]]); table.insert(xml, [[&lt;action application=<span class="code-quote">"bridge"</span> data=<span class="code-quote">"]]..didinfo[<span class="code-quote">'extensions'</span>]..[["</span>/&gt;]]); </pre> </div></div> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> elseif(tonumber(didinfo[<span class="code-quote">'call_type'</span>]) == 4 and didinfo[<span class="code-quote">'extensions'</span>] ~= '') then table.insert(xml, [[&lt;action application=<span class="code-quote">"set"</span> data=<span class="code-quote">"calltype=DIRECT-IP"</span>/&gt;]]); table.insert(xml, [[&lt;action application=<span class="code-quote">"bridge"</span> data=<span class="code-quote">"sofia/<span class="code-keyword">default</span>/]]..destination_number..[[@]]..didinfo[<span class="code-quote">'extensions'</span>]..[["</span>/&gt;]]); elseif(tonumber(didinfo[<span class="code-quote">'call_type'</span>]) == 5 and didinfo[<span class="code-quote">'extensions'</span>] ~= '') then table.insert(xml, [[&lt;action application=<span class="code-quote">"set"</span> data=<span class="code-quote">"calltype=DID@IP"</span>/&gt;]]); table.insert(xml, [[&lt;action application=<span class="code-quote">"bridge"</span> data=<span class="code-quote">"sofia/<span class="code-keyword">default</span>/]]..didinfo[<span class="code-quote">'extensions'</span>]..[["</span>/&gt;]]); </pre> </div></div> <p>Released in ASTPP v3.5. </p> <p>Ah thats good news. Will upgrade soon. </p> Development External issue ID 36 Rank 0|i008uv: