https://jira.astppbilling.org This file is an XML representation of an issue en-us 8.13.3 813003 14-01-2021 https://jira.astppbilling.org/browse/ASTPPCOM-357 ASTPP Community <p>This will probably need someone caring about it, because if anyone<br/> ever tries to upgrade their MySQL version, I'm not actually sure what<br/> will happen with invalid data like this. It probably will be worth testing.</p> <p>Probably a good idea to have an upgrade script that updates everything in<br/> the database as part of 3.6, and warn people that they can't upgrade<br/> MySQL until this is run, because it'll eat their data.</p> <p>Signed-Off-By: Rob Thomas &lt;xrobau@gmail.com&gt;<br/> Signed-Off-By: Rob Thomas &lt;rthomas@sangoma.com&gt;</p> ASTPPCOM-357

0000-00-00 is not a valid date. Set it to something more valid.

New Feature Done Done Samir Doshi Rob Thomas Mon, 2 Apr 2018 03:04:55 +0530 Thu, 1 Apr 2021 18:57:31 +0530 Thu, 1 Apr 2021 18:57:31 +0530 0 0 <p>The other option is to set it to NULL, rather than 0000. I've found a bunch of other issues with CDRs when things are missing, that it's probably better to use NULL rather than a random hardcoded date.</p> <p>You can see my first stab at it here: <a href="https://github.com/xrobau/ASTPP/commit/811e2ad6114160d196ed2cdd7ebbd4ed0b82e195#diff-2d3963eeca4f9b003b26dd9a83d1e8efR346" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/xrobau/ASTPP/commit/811e2ad6114160d196ed2cdd7ebbd4ed0b82e195#diff-2d3963eeca4f9b003b26dd9a83d1e8efR346</a> - but I'm not sure how you want to do it. Personally, I would generate the entire insert as a key =&gt; val array, and then use that to generate the SQL Insert. </p> <p>Similar to this code: <a href="https://github.com/FreePBX/framework/blob/release/13.0/amp_conf/htdocs/admin/libraries/BMO/Freepbx_conf.class.php#L1036" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/FreePBX/framework/blob/release/13.0/amp_conf/htdocs/admin/libraries/BMO/Freepbx_conf.class.php#L1036</a> </p> <p>Got it but I realize the validate date patches will create a problem for existing users as their database tables already have records with 0000-00-00 00:00:00 date. </p> <p>So If we need to replace it with validate date then need to plan about it. </p> <p>On other hand I am wondering what difference it will make If we will start using 1980-01-01 00:00:00 inplace of 0000-00-00 00:00:00. At this moment, system will also working fine with 0000-00-00 00:00:00 format. </p> <p>0000-00-00 is no longer a valid datetime.</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <div class="error"><span class="error">Unable to find source-code formatter for language: `.</span> Available languages are: actionscript, ada, applescript, bash, c, c#, c++, cpp, css, erlang, go, groovy, haskell, html, java, javascript, js, json, lua, none, nyan, objc, perl, php, python, r, rainbow, ruby, scala, sh, sql, swift, visualbasic, xml, yaml</div><pre> Welcome to the MariaDB monitor. Commands end with ; or \g. Your MariaDB connection id is 351989 Server version: 5.5.56-MariaDB MariaDB Server Copyright (c) 2000, 2017, Oracle, MariaDB Corporation Ab and others. Type <span class="code-quote">'help;'</span> or <span class="code-quote">'\h'</span> <span class="code-keyword">for</span> help. Type <span class="code-quote">'\c'</span> to clear the current input statement. MariaDB [(none)]&gt; connect asterisk Reading table information <span class="code-keyword">for</span> completion of table and column names You can turn off <span class="code-keyword">this</span> feature to get a quicker startup with -A Connection id: 351990 Current database: asterisk MariaDB [asterisk]&gt; create table x ( y datetime <span class="code-keyword">null</span> ); Query OK, 0 rows affected (0.02 sec) MariaDB [asterisk]&gt; insert into x values ( <span class="code-quote">'0000-00-00 00:00:00'</span> ); Query OK, 1 row affected (0.01 sec) MariaDB [asterisk]&gt; drop table x; Query OK, 0 rows affected (0.01 sec) MariaDB [asterisk]&gt; \q Bye </pre> </div></div> <p>`</p> <p>But on 5.7</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <div class="error"><span class="error">Unable to find source-code formatter for language: `.</span> Available languages are: actionscript, ada, applescript, bash, c, c#, c++, cpp, css, erlang, go, groovy, haskell, html, java, javascript, js, json, lua, none, nyan, objc, perl, php, python, r, rainbow, ruby, scala, sh, sql, swift, visualbasic, xml, yaml</div><pre> [root@db-1 ~]# mysql freeswitch Reading table information <span class="code-keyword">for</span> completion of table and column names You can turn off <span class="code-keyword">this</span> feature to get a quicker startup with -A Welcome to the MySQL monitor. Commands end with ; or \g. Your MySQL connection id is 1677352 Server version: 5.7.21-20-57-log Percona XtraDB Cluster (GPL), Release rel20, Revision 1702aea, WSREP version 29.26, wsrep_29.26 Copyright (c) 2009-2018 Percona LLC and/or its affiliates Copyright (c) 2000, 2018, Oracle and/or its affiliates. All rights reserved. Oracle is a registered trademark of Oracle Corporation and/or its affiliates. Other names may be trademarks of their respective owners. Type <span class="code-quote">'help;'</span> or <span class="code-quote">'\h'</span> <span class="code-keyword">for</span> help. Type <span class="code-quote">'\c'</span> to clear the current input statement. mysql&gt; create table x ( y datetime <span class="code-keyword">null</span> ); Query OK, 0 rows affected (0.01 sec) mysql&gt; insert into x values ( <span class="code-quote">'0000-00-00 00:00:00'</span> ); ERROR 1292 (22007): Incorrect datetime value: <span class="code-quote">'0000-00-00 00:00:00'</span> <span class="code-keyword">for</span> column <span class="code-quote">'y'</span> at row 1 mysql&gt; drop table x; Query OK, 0 rows affected (0.01 sec) mysql&gt; </pre> </div></div> <p>`</p> <p>However, as I'm working through these bugs, I think it will be better to just remove the 'not null' restriction, and use NULL instead.</p> Development External issue ID 357 Rank 0|i00au7: