Jira

Jira https://jira.astppbilling.org This file is an XML representation of an issue en-us

8.13.3

813003

14-01-2021

[ASTPPCOM-244] Rate Import with Mapper. (Updated Fix Supplied) https://jira.astppbilling.org/browse/ASTPPCOM-244 ASTPP Community <p>It is saying the records are processed, but nothing is actually inserted into the outbound routes table.</p> ASTPPCOM-244

Rate Import with Mapper. (Updated Fix Supplied)

New Feature Done Done Samir Doshi countrdd Tue, 10 Oct 2017 12:42:29 +0530 Thu, 1 Apr 2021 19:02:01 +0530 Thu, 1 Apr 2021 19:02:01 +0530 0 0 <p>When I print the Result from the bulk insert this is what is coming back.</p> <p>A PHP Error was encountered<br/> Severity: Warning<br/> Message: Missing argument 2 for rates_model::bulk_insert_termination_rate(), called in /var/www/html/astpp/application/modules/rates/controllers/rates.php on line 1331 and defined<br/> Filename: models/rates_model.php<br/> Line Number: 312<br/> A PHP Error was encountered<br/> Severity: Notice<br/> Message: Undefined variable: count<br/> Filename: models/rates_model.php<br/> Line Number: 331</p> <ul> <li> <ul> <li>Found problem and fixed, also noticed init_inc was not being uploaded after fix was applied.</li> </ul> </li> </ul> <p>Fix: </p> <p>Add Line Number 1304: $csv_data <span class="error">['init_inc']</span> = ($this->input->post ( "init_inc-select" )) ? $csv_data <span class="error">[$this->input->post ( "init_inc-select" )]</span> : "0";<br/> Add Line Number 1305: $csv_data <span class="error">['init_inc']</span> = ($this->input->post ( "init_inc-prefix" )) ? $this->input->post ( "init_inc-prefix" ) . $csv_data <span class="error">['init_inc']</span> : $csv_data <span class="error">['init_inc']</span>; <br/> Add Line Number 1326: $new_final_arr <span class="error">[$i]</span> <span class="error">['init_inc']</span> = isset ( $csv_data <span class="error">['init_inc']</span> ) ? $csv_data <span class="error">['init_inc']</span> : 0; </p> <p>at Line number 1287 Add: $row_count = 0;<br/> at Line number 1327 Add: $row_count ++;<br/> at line number 1335 add second argument $row_count<br/> $result = $this->rates_model->bulk_insert_termination_rate ( $new_final_arr,$row_count );</p> <p>Also, Found another bug....<br/> Lines 1299, 1301, 1303, 1306 and 1309<br/> "0" should be replaced with "".</p> <p>If not the logic is setting the value to 0, and then adding then concatenating the default/prefix value to 0. Making a default value of 6 into 60.</p> <p><a href="https://github.com/iNextrix/ASTPP/files/1375040/ASTPP35.patch.txt" class="external-link" target="_blank" rel="nofollow noopener">ASTPP35.patch.txt</a></p> <p>Thanks <span class="error">[~countrdd]</span> <br/> Is that possible for you to send PR for this modification so that we can verify and merge it with source?</p> <p>I have not masters pR's yet.</p> Development External issue ID 244 Rank 0|i00a53: