https://jira.astppbilling.org This file is an XML representation of an issue en-us 8.13.3 813003 14-01-2021 https://jira.astppbilling.org/browse/ASTPPCOM-182 ASTPP Community <p>I have seen that if there is an error type disposition that there is no billing to the customer or provider. Some errors should still be billed. The reason I say this is based o the following example:</p> <p>NORMAL_CLEARING = billable<br/> Origination_cancel = non-bill<br/> User_busy = non-bill</p> <p>This is correct I feel but I got the following disposition on some of the calls: RECOVERY_ON_TIMER_EXPIRE and the customer duration was set to 0 and debit / cost 0 but the provider billed me for the call. The duration was 72 seconds. I think what happened was there was a network error and loss of packets. The call dropped but ASTPP did not bill for the duration the call was active for.</p> <p>How can I choose what disposition must get billed for when there is a active duration or is this a bug to be fixed in ASTPP?</p> ASTPPCOM-182

Billing on error disposition

New Feature Done Done Samir Doshi fozzygo4 Sat, 4 Feb 2017 20:52:51 +0530 Thu, 1 Apr 2021 18:57:08 +0530 Thu, 1 Apr 2021 18:57:08 +0530 0 0 <p>That will require code modification as we have condition as below in cdr<br/> processing file,</p> <p>if ( ($dataVariable<span class="error">&#91;&#39;hangup_cause&#39;&#93;</span> != 'NORMAL_CLEARING') &amp;&amp;<br/> ($dataVariable<span class="error">&#91;&#39;hangup_cause&#39;&#93;</span> != 'ALLOTTED_TIMEOUT')) {<br/> $dataVariable<span class="error">&#91;&#39;billsec&#39;&#93;</span> = 0;<br/> }</p> <p>Comment that condition and check if that works for you.</p> <h2><a name="BestRegards"></a>Best Regards</h2> <p>Samir Doshi<br/> <em>iNextrix Technologie</em><em>s Pvt. Ltd</em>.<br/> <a href="http://www.inextrix.com" class="external-link" target="_blank" rel="nofollow noopener">http://www.inextrix.com</a></p> <p><em>Disclaimer:</em><br/> The information contained in this communication is confidential and may be<br/> legally privileged. It is intended solely for the use of the individual or<br/> entity to whom it is addressed and others authorised to receive it. If you<br/> are not the intended recipient you are hereby notified that any disclosure,<br/> copying, distribution or taking action in reliance of the contents of this<br/> information is strictly prohibited and may be unlawful.</p> <p>On Sat, Feb 4, 2017 at 8:52 PM, Stephen Forster &lt;notifications@github.com&gt;<br/> wrote:</p> <p>&gt; I have seen that if there is an error type disposition that there is no<br/> &gt; billing to the customer or provider. Some errors should still be billed.<br/> &gt; The reason I say this is based o the following example:<br/> &gt;<br/> &gt; NORMAL_CLEARING = billable<br/> &gt; Origination_cancel = non-bill<br/> &gt; User_busy = non-bill<br/> &gt;<br/> &gt; This is correct I feel but I got the following disposition on some of the<br/> &gt; calls: RECOVERY_ON_TIMER_EXPIRE and the customer duration was set to 0 and<br/> &gt; debit / cost 0 but the provider billed me for the call. The duration was 72<br/> &gt; seconds. I think what happened was there was a network error and loss of<br/> &gt; packets. The call dropped but ASTPP did not bill for the duration the call<br/> &gt; was active for.<br/> &gt;<br/> &gt; How can I choose what disposition must get billed for when there is a<br/> &gt; active duration or is this a bug to be fixed in ASTPP?<br/> &gt;<br/> &gt; —<br/> &gt; You are receiving this because you are subscribed to this thread.<br/> &gt; Reply to this email directly, view it on GitHub<br/> &gt; &lt;<a href="https://github.com/iNextrix/ASTPP/issues/182" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/iNextrix/ASTPP/issues/182</a>&gt;, or mute the thread<br/> &gt; &lt;<a href="https://github.com/notifications/unsubscribe-auth/AA6gcVJSCiU7VpPpbHRLjMunC6wuMSpGks5rZJfLgaJpZM4L3LWU" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/notifications/unsubscribe-auth/AA6gcVJSCiU7VpPpbHRLjMunC6wuMSpGks5rZJfLgaJpZM4L3LWU</a>&gt;<br/> &gt; .<br/> &gt;</p> <p>Thanks Samir,</p> <p>I did find that code in the FS scripts and commented it out. I also had to change the following code from <br/> <tt>if ($duration &gt; 0 &amp;&amp; ($dataVariable<span class="error">&#91;&#39;hangup_cause&#39;&#93;</span> == 'NORMAL_CLEARING' || $dataVariable<span class="error">&#91;&#39;hangup_cause&#39;&#93;</span> == 'ALLOTTED_TIMEOUT')) {</tt><br/> to<br/> <tt>if ($duration &gt; 0){</tt></p> <p>This I feel is correct because if there is actual billable seconds in a call then it should be charged for regardless of the disposition. It is up to us as our customers provider to look into networking issues that we could be at fault for and credit this customer should the fault be ours. The way it currently is will be beneficial to to customer every time but we will still pay for the calls to our providers.</p> <p>On a security note on this I feel it could be exploited if someone knows what to do. For example if a customer A calls to a number for 1 hour. He / she knows of this flaw and simple disconnects there internet / network cable from their phone. ASTPP does not receive a BYE signal from the phone so eventually times out. ASTPP will not give a NORMAL_CLEARING disposition so it will change the duration to 0 and the call for customer A is now free. </p> <p>I tested this theory with the code in place and its true. If I modify the code then the call still gets charged to the customer.</p> <p>Hope this helps.</p> <p>Hi Stephen,</p> <p>That is right. If that is the case then we can remove that condition and<br/> only focus on the duration of the calls for billing. No matters what<br/> disposition we have got from freeswitch.</p> <p>We will check it out further.</p> <h2><a name="BestRegards"></a>Best Regards</h2> <p>Samir Doshi<br/> <em>iNextrix Technologie</em><em>s Pvt. Ltd</em>.<br/> <a href="http://www.inextrix.com" class="external-link" target="_blank" rel="nofollow noopener">http://www.inextrix.com</a></p> <p><em>Disclaimer:</em><br/> The information contained in this communication is confidential and may be<br/> legally privileged. It is intended solely for the use of the individual or<br/> entity to whom it is addressed and others authorised to receive it. If you<br/> are not the intended recipient you are hereby notified that any disclosure,<br/> copying, distribution or taking action in reliance of the contents of this<br/> information is strictly prohibited and may be unlawful.</p> <p>On Mon, Feb 6, 2017 at 4:39 PM, Stephen Forster &lt;notifications@github.com&gt;<br/> wrote:</p> <p>&gt; Thanks Samir,<br/> &gt;<br/> &gt; I did find that code in the FS scripts and commented it out. I also had to<br/> &gt; change the following code from<br/> &gt; if ($duration &gt; 0 &amp;&amp; ($dataVariable<span class="error">&#91;&#39;hangup_cause&#39;&#93;</span> == 'NORMAL_CLEARING'<br/> &gt; || $dataVariable<span class="error">&#91;&#39;hangup_cause&#39;&#93;</span> == 'ALLOTTED_TIMEOUT')) {<br/> &gt; to<br/> &gt; if ($duration &gt; 0){<br/> &gt;<br/> &gt; This I feel is correct because if there is actual billable seconds in a<br/> &gt; call then it should be charged for regardless of the disposition. It is up<br/> &gt; to us as our customers provider to look into networking issues that we<br/> &gt; could be at fault for and credit this customer should the fault be ours.<br/> &gt; The way it currently is will be beneficial to to customer every time but we<br/> &gt; will still pay for the calls to our providers.<br/> &gt;<br/> &gt; On a security note on this I feel it could be exploited if someone knows<br/> &gt; what to do. For example if a customer A calls to a number for 1 hour. He /<br/> &gt; she knows of this flaw and simple disconnects there internet / network<br/> &gt; cable from their phone. ASTPP does not receive a BYE signal from the phone<br/> &gt; so eventually times out. ASTPP will not give a NORMAL_CLEARING disposition<br/> &gt; so it will change the duration to 0 and the call for customer A is now free.<br/> &gt;<br/> &gt; I tested this theory with the code in place and its true. If I modify the<br/> &gt; code then the call still gets charged to the customer.<br/> &gt;<br/> &gt; Hope this helps.<br/> &gt;<br/> &gt; —<br/> &gt; You are receiving this because you commented.<br/> &gt; Reply to this email directly, view it on GitHub<br/> &gt; &lt;<a href="https://github.com/iNextrix/ASTPP/issues/182#issuecomment-277651759" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/iNextrix/ASTPP/issues/182#issuecomment-277651759</a>&gt;, or mute<br/> &gt; the thread<br/> &gt; &lt;<a href="https://github.com/notifications/unsubscribe-auth/AA6gcWh4188wmVI50qhX5vEF3-IY09Qsks5rZv9ngaJpZM4L3LWU" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/notifications/unsubscribe-auth/AA6gcWh4188wmVI50qhX5vEF3-IY09Qsks5rZv9ngaJpZM4L3LWU</a>&gt;<br/> &gt; .<br/> &gt;</p> <p>@FozzyGo4 , Issue has been resolved. Please confirm. </p> Development External issue ID 182 Rank 0|i009rb: