https://jira.astppbilling.org This file is an XML representation of an issue en-us 8.13.3 813003 14-01-2021 https://jira.astppbilling.org/browse/ASTPPCOM-120 ASTPP Community <p>line 374----------<br/> `if (calleridinfo ~= nil) then<br/> if (calleridinfo<span class="error">&#91;&#39;cid_name&#39;&#93;</span> ~= '') then<br/> session:execute("set", "origination_caller_id_name="..calleridinfo<span class="error">&#91;&#39;cid_name&#39;&#93;</span>); <br/> end<br/> if (calleridinfo<span class="error">&#91;&#39;cid_number&#39;&#93;</span> ~= '') then<br/> session:execute("set", "origination_caller_id_number="..calleridinfo<span class="error">&#91;&#39;cid_number&#39;&#93;</span>); <br/> end<br/> end`</p> <p>there no 'cid_name' and 'cid_number' fields in the database<br/> the correct fields is 'callerid_name' and 'callerid_number' in 'accounts_callerid' table</p> ASTPPCOM-120

A small Bug in 'astpp.callingcard.functions.lua'

New Feature Done Declined Samir Doshi stopro bug_confirmed new_bug Wed, 28 Sep 2016 20:26:09 +0530 Sun, 27 Oct 2019 15:50:17 +0530 Tue, 1 Nov 2016 16:29:17 +0530 v3.1 0 0 <p>We will fix this issue soon.</p> <p>These are the variables which are getting value from other file and method. It doesn't have to do anything with database field. </p> <p><tt>calleridinfo = get_override_callerid(userinfo)</tt></p> <p>`function get_override_callerid(userinfo)<br/> local callerid<br/> local query = "SELECT * FROM "..TBL_ACCOUNTS_CALLERID.." WHERE accountid = "..userinfo<span class="error">&#91;&#39;id&#39;&#93;</span>.." AND status=0 LIMIT 1"; <br/> Logger.debug("<span class="error">&#91;GET_OVERRIDE_CALLERID&#93;</span> Query :" .. query)<br/> assert (dbh:query(query, function(u)<br/> callerid = u<br/> end)) <br/> return callerid<br/> end`</p> <p>Once calleridinfo get the value, it is extract the values from array and pushing into cid_name and cid_number with some conditions. </p> <p>Please look carefully at the code.</p> <p> calleridinfo get value from function get_override_callerid, this function just query the database. and return recordset callerid from table TBL_ACCOUNTS_CALLERID to array calleridinfo.</p> <p>this bug occur a error to set a callerid to customer. have a try pls.</p> <p>This bug needs to be resolved all the way from the front end.</p> <ul class="alternate" type="square"> <li>On "Force caller ID" overlay edit, why is "caller ID name" compulsory, when it is a "Yes|No" field at the higher level. I think the 2.0 implementation was better, where it was not a compulsory field.</li> <li>I assume selecting "enable: Yes" means "force caller ID"...but this breaks the call raising the lua error reported.</li> <li>calls only go through if "enable" is "NO", but then caller IDs are not forced. Rather the "caller ID caller name" and "caller ID caller number" on the SIP device is what is sent - and this can be edited by the customer.</li> </ul> <p>Meaning forcing caller ID does not presently work.</p> <p>Thanks for the fixes <span class="error">&#91;~smrdoshi&#93;</span><br/> Happy new month!</p> Development External issue ID 120 Rank 0|i009dj: