https://jira.astppbilling.org This file is an XML representation of an issue en-us 8.13.3 813003 14-01-2021 https://jira.astppbilling.org/browse/ASTPPCOM-118 ASTPP Community <p>Hi Team,</p> <p>I picked up an issue from my resellers. If they recharge their customers with any amount then their own balance (reseller balance) gets updated as well.</p> <p>Example: Reseller recharges a customer with 100. The customer balance is updated with 100 but so is the resellers balance.</p> <p>The reseller should not be updated.</p> ASTPPCOM-118

Reseller recharge

Task Done Done Unassigned fozzygo4 Sun, 25 Sep 2016 23:42:16 +0530 Tue, 20 Dec 2016 19:40:54 +0530 Tue, 20 Dec 2016 19:40:54 +0530 0 0 <p>Its not issue !<br/> Its feature because if reseller doesn't have any balance then call is not establish. so we are giving balance/credit to reseller as well so their customer can make call.</p> <p>That’s not logical. A resellers balance is determined and controlled by an admin of the reseller. Let me give an example.</p> <p>I am a admin (Company A) and I get a new reseller called Company B who wants to resell my services to their customers. I setup a pre-paid reseller account for B. B has 0 credit available because B needs to purchase call credit to be able to sell the credit to his customers. B purchases $100 and admin A loads a payment to reseller B for $100. B's balance is now $100 and B's customers can now make calls.</p> <p>Now B has customer C. Customer C is pre-paid. Customer C will deduct the cost of the calls from the reseller B's balance and be debited from their own balance.</p> <p>C purchases credit from reseller B of $50.00. Reseller B adds a payment to C of $50. C's balance is now $50 and can make calls but reseller B should still remain at $100 because no calls have been made. If C makes a call for $1 then it should be deducted from C's balance as well as reseller B (Provided there is now profit added, B should be $99 and C should be $49 after the call). If there is profit and C makes a call for $1 and the cost is 50c then $1 is deducted from C and 50c is deducted from reseller B. I’m sure you will agree this is how it works and is logical. This is how it works with ASTPP version 2.</p> <p>Now in version 3 it works like so and I will point out why it is wrong.</p> <p>Same scenario as above with the setup so we have admin A, reseller B and customer of reseller B called C. B purchases credit from A to be able to sell calls to their customers. B has $100 that they can now sell and I (Admin A) have been paid $100 from B.</p> <p>C now purchases $50 from reseller B. B adds a payment to C for $50. C's balance is now $50 but reseller B is now $150. Admin A did not sell the extra $50 to reseller B.</p> <p>Admin A is now losing money because the resellers balance is not controlled by the administrator. </p> <p>In ASTPP Version 2, when C was making payment via paypal, all actual money was going to admin's paypal account and reseller was not getting anything. Then admin has to recharge reseller's account manually upon their request as customer C's actual money went to admin's paypal account. Handing manual process of recharge between admin and reseller was lengthy and not proper, so we automated the process in Version 3. </p> <p>Now in Version 3, when customer C is making payment via paypal, all actual money will goes to admin's paypal account but along with that same amount of recharge will be done in reseller's account. So neither admin nor reseller has to bother each other for payment whenever their customer (C) do the payment. </p> <p>Hope you understand. Let me know if have any further concern about the same. </p> <p>Hi Samir,</p> <p>We don’t use PayPal and prefer to use the manual process. Even if we did use Paypal then why is the reseller getting credited with the money that should go towards the customer. The reseller is my customer and I need to manage the resellers credit / debit. Can I chat to you on Skype and perhaps I can show you what I mean via teamviewer.</p> <p>Regards</p> <p>STEPHEN FORSTER<br/> GO 4 IT SOLUTIONS (PTY) LTD.</p> <p><span class="error">&#91;cid:image001.png@01D21805.A0966680&#93;</span><br/> DISCLAIMER: This document is for the personal and private attention of the addressee and should be read by the addressee only. Go 4 IT Solutions (Pty) Ltd, its subsidiaries and/or any of its associate companies accepts no liability and/or responsibility whatsoever for all and any consequences arising out of but not limited to the receipt by a party, other than the addressee, of this communication. If you have received this communication in error, please notify us immediately thereof by telephone. Kindly destroy this communication immediately. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and/or publication of this communication are strictly prohibited.</p> <p>Reception:</p> <p>+27 (0) 10 591-2099</p> <p>Direct:</p> <p>+27 (0) 10 591-2105</p> <p>Mobile:</p> <p>+27 (0) 83 650-8600</p> <p>Skype:</p> <p>Stephen-fozzy</p> <p>E-mail:</p> <p>stephen@go4.co.za</p> <p>Web:</p> <p><a href="http://www.go4.co.zahttp://www.go4.co.za/" class="external-link" target="_blank" rel="nofollow noopener">http://www.go4.co.zahttp://www.go4.co.za/</a></p> <p>From: Samir Doshi notifications@github.com<br/> Reply-To: iNextrix/ASTPP reply@reply.github.com<br/> Date: Monday, 26September, 2016 at 2:27 PM<br/> To: iNextrix/ASTPP ASTPP@noreply.github.com<br/> Cc: Stephen Forster stephen@go4.co.za, Author author@noreply.github.com<br/> Subject: Re: <span class="error">&#91;iNextrix/ASTPP&#93;</span> Reseller recharge (<a href="https://jira.astppbilling.org/browse/ASTPPCOM-118" title="Reseller recharge" class="issue-link" data-issue-key="ASTPPCOM-118"><del>ASTPPCOM-118</del></a>)</p> <p>In ASTPP Version 2, when C was making payment via paypal, all actual money was going to admin's paypal account and reseller was not getting anything. Then admin has to recharge reseller's account manually upon their request as customer C's actual money went to admin's paypal account. Handing manual process of recharge between admin and reseller was lengthy and not proper, so we automated the process in Version 3.</p> <p>Now in Version 3, when customer C is making payment via paypal, all actual money will goes to admin's paypal account but along with that same amount of recharge will be done in reseller's account. So neither admin nor reseller has to bother each other for payment whenever their customer (C) do the payment.</p> <p>Hope you understand. Let me know if have any further concern about the same.</p> <p>—<br/> You are receiving this because you authored the thread.<br/> Reply to this email directly, view it on GitHubhttps://github.com/iNextrix/ASTPP/issues/118#issuecomment-249555745, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AT8i_3PAlyqO21-TbCDfduTW2EuRq57Yks5qt7oUgaJpZM4KF9q7.</p> <p>Hi Samir, I need you to please assist me in understanding why this new way of recharging reseller customers is also topping up the reseller account at the same time.</p> <p>If I am the supplier to the reseller and my reseller is pre-paid then the resellers balance should only be effected when I the admin top-up the resellers account.</p> <p>Right now the reseller is able to top-up his own account just by topping up his customer account. Surely you understand that this is not the correct way. How must I the admin now control how much credit the reseller has. In this scenario he will never run out of credit.</p> <p>Please take a closer look at the problem and maybe we can have a Skype / Teamviewer session so that I can show you what I mean.</p> <p>Hi Stephen,</p> <p>Lets have discussion on Monday for the same. Will ping you on skype.</p> <h2><a name="BestRegards"></a>Best Regards</h2> <p>Samir Doshi<br/> <em>iNextrix Technologie</em><em>s Pvt. Ltd</em>.<br/> <a href="http://www.inextrix.com" class="external-link" target="_blank" rel="nofollow noopener">http://www.inextrix.com</a></p> <p><em>Disclaimer:</em><br/> The information contained in this communication is confidential and may be<br/> legally privileged. It is intended solely for the use of the individual or<br/> entity to whom it is addressed and others authorised to receive it. If you<br/> are not the intended recipient you are hereby notified that any disclosure,<br/> copying, distribution or taking action in reliance of the contents of this<br/> information is strictly prohibited and may be unlawful.</p> <p>On Sat, Oct 1, 2016 at 12:16 PM, Stephen Forster notifications@github.com<br/> wrote:</p> <p>&gt; Hi Samir, I need you to please assist me in understanding why this new way<br/> &gt; of recharging reseller customers is also topping up the reseller account at<br/> &gt; the same time.<br/> &gt; <br/> &gt; If I am the supplier to the reseller and my reseller is pre-paid then the<br/> &gt; resellers balance should only be effected when I the admin top-up the<br/> &gt; resellers account.<br/> &gt; <br/> &gt; Right now the reseller is able to top-up his own account just by topping<br/> &gt; up his customer account. Surely you understand that this is not the correct<br/> &gt; way. How must I the admin now control how much credit the reseller has. In<br/> &gt; this scenario he will never run out of credit.<br/> &gt; <br/> &gt; Please take a closer look at the problem and maybe we can have a Skype /<br/> &gt; Teamviewer session so that I can show you what I mean.<br/> &gt; <br/> &gt; —<br/> &gt; You are receiving this because you commented.<br/> &gt; Reply to this email directly, view it on GitHub<br/> &gt; <a href="https://github.com/iNextrix/ASTPP/issues/118#issuecomment-250896428" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/iNextrix/ASTPP/issues/118#issuecomment-250896428</a>, or mute<br/> &gt; the thread<br/> &gt; <a href="https://github.com/notifications/unsubscribe-auth/AA6gcauC0AYCP8tSnhM6olZA5c_TiFT2ks5qvgG7gaJpZM4KF9q7" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/notifications/unsubscribe-auth/AA6gcauC0AYCP8tSnhM6olZA5c_TiFT2ks5qvgG7gaJpZM4KF9q7</a><br/> &gt; .</p> <p>Awesome thanks!</p> <p>Hi Samir,</p> <p>It has been a while since we chatted. I had some time to go through the code in libraries &gt; accounts.php</p> <p>I commented out the following code and it has fixed my issue with the resellers balance being updated at the same time as the resellers customers balance when processing a manual payment.</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-keyword">if</span>($login_user_data[<span class="code-quote">'type'</span>] ==1){ $reseller_ids=$<span class="code-keyword">this</span>-&gt;common-&gt;get_parent_info($login_user_data[<span class="code-quote">'id'</span>],0); $reseller_ids=rtrim($reseller_ids,<span class="code-quote">","</span>); $reseller_arr=explode(<span class="code-quote">","</span>,$reseller_ids); <span class="code-keyword">if</span>(!empty($reseller_arr)){ $custom_array=$post_array; foreach($reseller_arr as $key=&gt;$reseller_id){ $custom_array[<span class="code-quote">'id'</span>]=$reseller_id; $response = $<span class="code-keyword">this</span>-&gt;accounts_model-&gt;account_process_payment($custom_array); $reseller_info=(array)$<span class="code-keyword">this</span>-&gt;db-&gt;get_where(<span class="code-quote">'accounts'</span>,array(<span class="code-quote">"id"</span>=&gt;$reseller_id))-&gt;first_row(); $last_invoice_ID = $<span class="code-keyword">this</span>-&gt;get_invoice_date(<span class="code-quote">"invoiceid"</span>,$reseller_info[<span class="code-quote">"id"</span>]); $invoice_id=$<span class="code-keyword">this</span>-&gt;invoices-&gt;invoices-&gt;generate_receipt($reseller_info[<span class="code-quote">'id'</span>],$custom_array[<span class="code-quote">'credit'</span>],$reseller_info,$last_invoice_ID+1,$invoice_prefix,$due_date); $account_balance = $<span class="code-keyword">this</span>-&gt;common-&gt;get_field_name(<span class="code-quote">'balance'</span>, <span class="code-quote">'accounts'</span>, $reseller_info[<span class="code-quote">'id'</span>]); $insert_arr = array(<span class="code-quote">"accountid"</span> =&gt; $reseller_info[<span class="code-quote">'id'</span>], <span class="code-quote">"description"</span> =&gt; trim($custom_array[<span class="code-quote">'notes'</span>]), <span class="code-quote">"debit"</span> =&gt; 0, <span class="code-quote">"credit"</span> =&gt; $custom_array[<span class="code-quote">'credit'</span>], <span class="code-quote">"created_date"</span> =&gt; gmdate(<span class="code-quote">"Y-m-d H:i:s"</span>), <span class="code-quote">"invoiceid"</span>=&gt;$invoice_id, <span class="code-quote">"reseller_id"</span>=&gt;$reseller_info[<span class="code-quote">'reseller_id'</span>], <span class="code-quote">"item_type"</span>=&gt;<span class="code-quote">'Refill'</span>, <span class="code-quote">"item_id"</span>=&gt;<span class="code-quote">'0'</span>, <span class="code-quote">'before_balance'</span>=&gt;$account_balance-$custom_array[<span class="code-quote">'credit'</span>], <span class="code-quote">'after_balance'</span>=&gt;$account_balance, ); $<span class="code-keyword">this</span>-&gt;db-&gt;insert(<span class="code-quote">"invoice_details"</span>, $insert_arr); } } } </pre> </div></div> <p>Thanks Stephen. We will check it out and do needful.</p> <h2><a name="BestRegards"></a>Best Regards</h2> <p>Samir Doshi<br/> <em>iNextrix Technologie</em><em>s Pvt. Ltd</em>.<br/> <a href="http://www.inextrix.com" class="external-link" target="_blank" rel="nofollow noopener">http://www.inextrix.com</a></p> <p><em>Disclaimer:</em><br/> The information contained in this communication is confidential and may be<br/> legally privileged. It is intended solely for the use of the individual or<br/> entity to whom it is addressed and others authorised to receive it. If you<br/> are not the intended recipient you are hereby notified that any disclosure,<br/> copying, distribution or taking action in reliance of the contents of this<br/> information is strictly prohibited and may be unlawful.</p> <p>On Mon, Dec 19, 2016 at 1:25 PM, Stephen Forster &lt;notifications@github.com&gt;<br/> wrote:</p> <p>&gt; Hi Samir,<br/> &gt;<br/> &gt; It has been a while since we chatted. I had some time to go through the<br/> &gt; code in libraries &gt; accounts.php<br/> &gt;<br/> &gt; I commented out the following code and it has fixed my issue with the<br/> &gt; resellers balance being updated at the same time as the resellers customers<br/> &gt; balance when processing a manual payment.<br/> &gt;<br/> &gt; if($login_user_data<span class="error">&#91;&#39;type&#39;&#93;</span> ==1){<br/> &gt; $reseller_ids=$this-&gt;common-&gt;get_parent_info($login_user_data<span class="error">&#91;&#39;id&#39;&#93;</span>,0);<br/> &gt; $reseller_ids=rtrim($reseller_ids,",");<br/> &gt; $reseller_arr=explode(",",$reseller_ids);<br/> &gt; if(!empty($reseller_arr)){<br/> &gt; $custom_array=$post_array;<br/> &gt; foreach($reseller_arr as $key=&gt;$reseller_id)</p> { &gt; $custom_array['id']=$reseller_id; &gt; $response = $this-&gt;accounts_model-&gt;account_process_payment($custom_array); &gt; $reseller_info=(array)$this-&gt;db-&gt;get_where('accounts',array("id"=&gt;$reseller_id))-&gt;first_row(); &gt; $last_invoice_ID = $this-&gt;get_invoice_date("invoiceid",$reseller_info["id"]); &gt; $invoice_id=$this-&gt;invoices-&gt;invoices-&gt;generate_receipt($reseller_info['id'],$custom_array['credit'],$reseller_info,$last_invoice_ID+1,$invoice_prefix,$due_date); &gt; $account_balance = $this-&gt;common-&gt;get_field_name('balance', 'accounts', $reseller_info['id']); &gt; $insert_arr = array("accountid" =&gt; $reseller_info['id'], &gt; "description" =&gt; trim($custom_array['notes']), &gt; "debit" =&gt; 0, &gt; "credit" =&gt; $custom_array['credit'], &gt; "created_date" =&gt; gmdate("Y-m-d H:i:s"), &gt; "invoiceid"=&gt;$invoice_id, &gt; "reseller_id"=&gt;$reseller_info['reseller_id'], &gt; "item_type"=&gt;'Refill', &gt; "item_id"=&gt;'0', &gt; 'before_balance'=&gt;$account_balance-$custom_array['credit'], &gt; 'after_balance'=&gt;$account_balance, &gt; ); &gt; $this-&gt;db-&gt;insert("invoice_details", $insert_arr); &gt; } <p>&gt; }<br/> &gt; }<br/> &gt;<br/> &gt;<br/> &gt; —<br/> &gt; You are receiving this because you commented.<br/> &gt; Reply to this email directly, view it on GitHub<br/> &gt; &lt;<a href="https://github.com/iNextrix/ASTPP/issues/118#issuecomment-267902747" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/iNextrix/ASTPP/issues/118#issuecomment-267902747</a>&gt;, or mute<br/> &gt; the thread<br/> &gt; &lt;<a href="https://github.com/notifications/unsubscribe-auth/AA6gcRxh_XuyFN0k5IdxF2glTgQsuYxYks5rJjh8gaJpZM4KF9q7" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/notifications/unsubscribe-auth/AA6gcRxh_XuyFN0k5IdxF2glTgQsuYxYks5rJjh8gaJpZM4KF9q7</a>&gt;<br/> &gt; .<br/> &gt;</p> Development External issue ID 118 Rank 0|i009d3: