[ASTPPCOM-529] New SIP profile doesn't give correct rtp-ip Created: 28/Jun/19  Updated: 27/Oct/19  Resolved: 27/Oct/19

Status: Done
Project: ASTPP Community
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: New Feature
Reporter: teammorris Assignee: Samir Doshi
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

When creating a new SIP profile, the rtp-ip setting is incorrected called rtp_ip. This means that freeswitch will not present the IP address of the new profile when sending an INVITE on the new SIP profile, instead freeswitch will give the IP of the default ipv4 address.

 Comments   
Comment by teammorris [ 28/Jun/19 ]

I have fixed this in the code and created a new branch locally. When I try to push my new branch to the repository I am told I am not authorised. Are you able to allow me to have new branch and then pull request access to contribute bug fixes?
I checked https://astpp.readthedocs.io/en/v4.0/Introduction/how_to_contribute.html but this doesn't say how to contribute bug fixes.

Thanks,
David

Comment by teammorris [ 02/Jul/19 ]

I see now that I need to fork the repository, make the fixes in the new repository then doa pull request from there.

Comment by Samir Doshi [ 05/Jul/19 ]

Hi David,

Sorry for the late reply.
Yes thats the right way.

If you need any help in that then please let us know.

Sent from Google Pixel 2

On Tue, Jul 2, 2019, 5:56 PM David Morris <notifications@github.com> wrote:

> I see now that I need to fork the repository, make the fixes in the new
> repository then doa pull request from there.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/iNextrix/ASTPP/issues/529?email_source=notifications&email_token=AAHKA4PX2E4GMB6LIOBAGHDP5NCNTA5CNFSM4H4D6MQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZBDAOA#issuecomment-507654200>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAHKA4OHSKW3CQLQQATINWLP5NCNTANCNFSM4H4D6MQQ>
> .
>

Generated at Sat Feb 10 07:17:59 CET 2024 using Jira 8.13.3#813003-sha1:22ebedbb75c99b147c66f14e031dd8a2d214753a.