[ASTPPCOM-472] Use company favicon Created: 17/Nov/18  Updated: 01/Apr/21  Resolved: 01/Apr/21

Status: Done
Project: ASTPP Community
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: New Feature
Reporter: aikajee Assignee: Samir Doshi
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

Use company favicon from Portal section of Company profile page in login.

 Comments   
Comment by Samir Doshi [ 19/Nov/18 ]

Hi [~aikajee]

Thanks for the contribution.
would you please explain what issue it will resolve exactly?

Comment by aikajee [ 19/Nov/18 ]

Hi,

The login screen does not display the uploaded favicon. It defaults to the
standard ASTPP favicon. The small fix, taken from the dashboard view fixes
the issue by checking for the custom uploaded favicon and if found uses it.
If not found, it defaults to the standard ASTPP favicon.

Regards,
Ahmed.

On Mon, Nov 19, 2018 at 6:40 AM Samir Doshi <notifications@github.com>
wrote:

> Hi [~aikajee] <https://github.com/aikajee>
>
> Thanks for the contribution.
> would you please explain what issue it will resolve exactly?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/iNextrix/ASTPP/pull/472#issuecomment-439865032>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/ArBvPczOU6Tr52-On9T0-8MkYbWr-EYYks5uwpiwgaJpZM4YnVGm>
> .
>

–

Comment by Samir Doshi [ 20/Nov/18 ]

Thanks. Merged!!

Generated at Sat Feb 10 07:17:27 CET 2024 using Jira 8.13.3#813003-sha1:22ebedbb75c99b147c66f14e031dd8a2d214753a.