[ASTPPCOM-446] Currency import using 1forge.com API & add conversion loss % calculation Created: 28/Jun/18  Updated: 01/Apr/21  Resolved: 01/Apr/21

Status: Done
Project: ASTPP Community
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: New Feature
Reporter: alexheylin Assignee: Samir Doshi
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

Currency import using 1forge.com API
Add conversion loss % calculation
Add two fields to system table to support this.

Note: need to import SQL manually for now, as expecting this to be integrated into v3.7 upgrade file.

 Comments   
Comment by (Community) DN (Inactive) [ 02/Jul/18 ]

[~AlexHeylin] Thanks for the PR. We'll observe the implementation, analyze its impact on other features and flow and merge it once confirm.

Comment by alexheylin [ 19/Jul/18 ]

[~smrdoshi] - Thanks for pointing that out. I actually copied it from

Unable to find source-code formatter for language: web_interface. Available languages are: actionscript, ada, applescript, bash, c, c#, c++, cpp, css, erlang, go, groovy, haskell, html, java, javascript, js, json, lua, none, nyan, objc, perl, php, python, r, rainbow, ruby, scala, sh, sql, swift, visualbasic, xml, yaml
/astpp/application/controllers/ProcessInvoice.php

This tests OK on my test system, and I'm happy for you to commit if you are happy.
Thanks!

Comment by Samir Doshi [ 20/Jul/18 ]

Yes. Please, let's do it.
Also thanks for pointing out processinvoice.php with static path. We will
update that file.

[image: Mailtrack]
<https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality6&>
Sender
notified by
Mailtrack
<https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality6&>
07/20/18,
10:48:59 AM

Best Regards

Samir Doshi
iNextrix Technologies Pvt. Ltd.
http://www.inextrix.com

Disclaimer:
The information contained in this communication is confidential and may be
legally privileged. It is intended solely for the use of the individual or
entity to whom it is addressed and others authorized to receive it. If you
are not the intended recipient you are hereby notified that any disclosure,
copying, distribution or taking action in reliance on the contents of this
information is strictly prohibited and may be unlawful. Please notify the
sender immediately and destroy all copies of this message and any
attachments contained in it.

On Fri, Jul 20, 2018 at 1:40 AM, AlexHeylin <notifications@github.com>
wrote:

> [~smrdoshi] <https://github.com/smrdoshi> - Thanks for pointing that out. I
> actually copied it from web_interface/astpp/application/controllers/
> ProcessInvoice.php
> This tests OK on my test system, and I'm happy for you to commit if you
> are happy.
> Thanks!
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/iNextrix/ASTPP/pull/446#issuecomment-406398999>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AA6gcdf8KLNkmb52Hv5_zSmWxfZ01Psbks5uIOevgaJpZM4U7-MH>
> .
>

Comment by alexheylin [ 03/Aug/18 ]

This has worked well in both my dev and prod environments so please merge. Will you merge this, or do you want me to submit a new request? Thanks

Comment by Samir Doshi [ 11/Aug/18 ]

Will do.

On Sat, Aug 4, 2018, 12:10 AM AlexHeylin <notifications@github.com> wrote:

> This has worked well in both my dev and prod environments so please merge.
> Will you merge this, or do you want me to submit a new request? Thanks
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/iNextrix/ASTPP/pull/446#issuecomment-410341629>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AA6gcS_5xehtmpbkoMmNYTeRo-65jWSVks5uNJkqgaJpZM4U7-MH>
> .
>

Generated at Sat Feb 10 07:17:12 CET 2024 using Jira 8.13.3#813003-sha1:22ebedbb75c99b147c66f14e031dd8a2d214753a.