[ASTPPCOM-445] Currency import broken by retired API (again) Created: 27/Jun/18 Updated: 01/Apr/21 Resolved: 01/Apr/21 |
|
| Status: | Done |
| Project: | ASTPP Community |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | New Feature | ||
| Reporter: | alexheylin | Assignee: | Samir Doshi |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
Shortly after this was kindly rewritten in v3.6, fixer.io retired the old API and the new one only allows the base currency to be EUR in the free plan. Doh! I'm working on changing to a new API. I'll probably use https://1forge.com/forex-data-api/pricing unless anyone has better suggestion? Needs to allow a choice of base currency, and be free then very cheap for low usage. We'll encourage users to pay, but ideally not require them to in order to use the feature. I'm also looking to add ability to allow for a percentage to be lost in currency conversion, so rate in ASTPP DB is closer to the rate you actually get and not the "wholesale" rate from the API. This can cover bank charges etc. I'll submit PR when ready. |
| Comments |
| Comment by alexheylin [ 28/Jun/18 ] |
|
PR issued https://github.com/iNextrix/ASTPP/pull/446 |
| Comment by Samir Doshi [ 12/Jul/18 ] |
|
Closing this issue as we are going to merge PR |