[ASTPPCOM-432] Some DB columns types do not match across tables Created: 02/Jun/18  Updated: 01/Apr/21  Resolved: 01/Apr/21

Status: Done
Project: ASTPP Community
Component/s: None
Affects Version/s: None
Fix Version/s: v4.0.2

Type: New Feature
Reporter: alexheylin Assignee: Samir Doshi
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

I came across this while building a relationship diagram for the DB.
For example:

  • astpp.sweeplist.id = int(10) unsigned -> astpp.accounts.sweep_id = tinyint(1)
  • astpp.sweeplist.id = int(10) unsigned -> astpp.charges.sweep_id = int(1)
  • astpp.cdrs.trunk_id = smallint(6) -> astpp.trunks.id = int(11)
  • astpp.cdrs.pricelist_id = smallint(6) -> astpp.pricelists.id = int(11)
  • astpp.ip_map.pricelist_id = int(4) -> astpp.pricelists.id = int(11)
  • astpp.packages.pricelist_id = int(4) -> astpp.pricelists.id = int(11)
  • astpp.reseller_cdrs.pricelist_id = smallint(6) -> astpp.pricelists.id = int(11)


 Comments   
Comment by (Community) DN (Inactive) [ 08/Jun/18 ]

[~AlexHeylin] Thanks for pointing this out, we'll consider it. Or better, if you can send us the PR with above modifications.

Comment by alexheylin [ 08/Jun/18 ]

I'll test this in my dev and send you PR when ready. Thanks

On Fri, 8 Jun 2018, 08:21 Devang Nathwani, <notifications@github.com> wrote:

> [~AlexHeylin] <https://github.com/AlexHeylin> Thanks for pointing this out,
> we'll consider it. Or better, if you can send us the PR with above
> modifications.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/iNextrix/ASTPP/issues/432#issuecomment-395672552>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AAQifYUwnK2qcePYBbMirStN5JALgy7rks5t6iXlgaJpZM4UX2iH>
> .
>

Comment by alexheylin [ 30/Jun/18 ]

This is what I'm testing in my dev

astpp.sweeplist.id = int(10) unsigned -> astpp.accounts.sweep_id = tinyint(1)

 
ALTER TABLE `accounts` CHANGE COLUMN `sweep_id` `sweep_id` INT(10) UNSIGNED NOT NULL 
DEFAULT '0' COMMENT 'Sweep list table id' AFTER `status`;

astpp.sweeplist.id = int(10) unsigned -> astpp.charges.sweep_id = int(1)

ALTER TABLE `charges`CHANGE COLUMN `sweep_id` `sweep_id` INT(10) UNSIGNED NOT NULL 
DEFAULT '0' COMMENT 'sweeplist table id' AFTER `pro_rate`;

astpp.cdrs.trunk_id = smallint(6) -> astpp.trunks.id = int(11)

ALTER TABLE `cdrs` CHANGE COLUMN `trunk_id` `trunk_id` INT(11) NOT NULL 
DEFAULT '0' AFTER `billseconds`;

astpp.cdrs.pricelist_id = smallint(6) -> astpp.pricelists.id = int(11)

ALTER TABLE `cdrs` CHANGE COLUMN `pricelist_id` `pricelist_id` INT(11) NOT NULL 
DEFAULT '0' AFTER `provider_id`;

astpp.ip_map.pricelist_id = int(4) -> astpp.pricelists.id = int(11)

ALTER TABLE `ip_map` CHANGE COLUMN `pricelist_id` `pricelist_id` INT(11) NOT NULL 
DEFAULT '0' AFTER `accountid`;

astpp.packages.pricelist_id = int(4) -> astpp.pricelists.id = int(11)

 
ALTER TABLE `packages` CHANGE COLUMN `pricelist_id` `pricelist_id` INT(11) NOT NULL 
DEFAULT '0' COMMENT 'pricelist table id' AFTER `package_name`;

astpp.reseller_cdrs.pricelist_id = smallint(6) -> astpp.pricelists.id = int(11)

ALTER TABLE `reseller_cdrs` CHANGE COLUMN `package_id` `package_id` INT(11) NOT NULL 
DEFAULT '0' AFTER `pricelist_id`;
Comment by Samir Doshi [ 12/Jul/18 ]

Hi [~AlexHeylin]

Does it work well?
If so, please send PR.

Comment by Samir Doshi [ 08/Sep/18 ]

Hi (Community) DN

Please do needful to update to sql.

Comment by hemdip [ 20/Jun/19 ]

[~AlexHeylin] It has been fixed in V-4.0, you can update version and verify.

Generated at Sat Feb 10 07:17:05 CET 2024 using Jira 8.13.3#813003-sha1:22ebedbb75c99b147c66f14e031dd8a2d214753a.