[ASTPPCOM-414] Current WIP Created: 28/Apr/18 Updated: 01/Apr/21 Resolved: 01/Apr/21 |
|
| Status: | Done |
| Project: | ASTPP Community |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | New Feature | ||
| Reporter: | Rob Thomas (Inactive) | Assignee: | Samir Doshi |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
This is the 3.6 branch with all the current fixes applied, APART from the ones I mentioned in glitter. Also:
This would be a good starting point for 3.7! |
| Comments |
| Comment by Rob Thomas (Inactive) [ 28/Apr/18 ] |
|
Most of the conflicts are either ^M repairs, or short-php-opens. I haven't looked too hard. Also, I haven't even checked if this code works, this was just getting my branch up to date with yours. There may be more commits coming. |
| Comment by Samir Doshi [ 03/May/18 ] |
|
Hi Rob Thomas Thanks for the updates. |
| Comment by Rob Thomas (Inactive) [ 03/May/18 ] |
|
The merge conflicts aren't really fixable, if you look through them, because they're differences in the entire file (eg, remove ^M's) or different ways of doing things. You get to pick what you want to merge 8) Github has a surprisingly good 'resolve conflicts' button. |
| Comment by Samir Doshi [ 03/May/18 ] |
|
Alright. I will look at that. [image: Mailtrack] Best RegardsSamir Doshi Disclaimer: On Thu, May 3, 2018 at 11:51 AM, Rob Thomas <notifications@github.com> > The merge conflicts aren't really fixable, if you look through them, |
| Comment by Rob Thomas (Inactive) [ 13/May/18 ] |
|
I'm not going to persevere with this pull request, as it's just getting more and more stale. Plus commits like https://github.com/iNextrix/ASTPP/commit/309a35a5f1bc2a8aa4fb44deff1cbf3103669528 where one file was randomly placed inside another (breaking all CDRs) really disheartens me. |
| Comment by Samir Doshi [ 13/May/18 ] |
|
Hi Rob, That was unfortunate bug and I hope there will not be any other. How would you like to keep your branch running? On Sun 13 May, 2018, 4:33 AM Rob Thomas, <notifications@github.com> wrote: > Closed |