[ASTPPCOM-414] Current WIP Created: 28/Apr/18  Updated: 01/Apr/21  Resolved: 01/Apr/21

Status: Done
Project: ASTPP Community
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: New Feature
Reporter: Rob Thomas (Inactive) Assignee: Samir Doshi
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

This is the 3.6 branch with all the current fixes applied, APART from the ones I mentioned in glitter.

Also:

  • Remove all PHP short open tags
  • Fixes all PHP warnings, so it can be run with php 7
  • Much better error reporting, and all error reporting turned ON (so hopefully it never gets as buggy as it was again!)
  • Support for MySQL 5.7
    • Note this uses 01-01-1980 as a replacement for the (invalid) 00-00-0000 datestamp. The better way to do that is to allow NULL datestamps, which is partially done

This would be a good starting point for 3.7!



 Comments   
Comment by Rob Thomas (Inactive) [ 28/Apr/18 ]

Most of the conflicts are either ^M repairs, or short-php-opens. I haven't looked too hard. Also, I haven't even checked if this code works, this was just getting my branch up to date with yours. There may be more commits coming.

Comment by Samir Doshi [ 03/May/18 ]

Hi Rob Thomas

Thanks for the updates.
Merge conflicts are there, are you planning to add more commits on this branch?

Comment by Rob Thomas (Inactive) [ 03/May/18 ]

The merge conflicts aren't really fixable, if you look through them, because they're differences in the entire file (eg, remove ^M's) or different ways of doing things. You get to pick what you want to merge 8)

Github has a surprisingly good 'resolve conflicts' button.

Comment by Samir Doshi [ 03/May/18 ]

Alright. I will look at that.

[image: Mailtrack]
<https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality4&>
Sender
notified by
Mailtrack
<https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality4&>

Best Regards

Samir Doshi
iNextrix Technologies Pvt. Ltd.
http://www.inextrix.com

Disclaimer:
The information contained in this communication is confidential and may be
legally privileged. It is intended solely for the use of the individual or
entity to whom it is addressed and others authorized to receive it. If you
are not the intended recipient you are hereby notified that any disclosure,
copying, distribution or taking action in reliance on the contents of this
information is strictly prohibited and may be unlawful. Please notify the
sender immediately and destroy all copies of this message and any
attachments contained in it.

On Thu, May 3, 2018 at 11:51 AM, Rob Thomas <notifications@github.com>
wrote:

> The merge conflicts aren't really fixable, if you look through them,
> because they're differences in the entire file (eg, remove ^M's) or
> different ways of doing things. You get to pick what you want to merge 8)
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/iNextrix/ASTPP/pull/414#issuecomment-386200966>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AA6gceMQIbd3Pg7mGRGvt7fIiHZSe4WSks5tuqHhgaJpZM4TrLwM>
> .
>

Comment by Rob Thomas (Inactive) [ 13/May/18 ]

I'm not going to persevere with this pull request, as it's just getting more and more stale. Plus commits like https://github.com/iNextrix/ASTPP/commit/309a35a5f1bc2a8aa4fb44deff1cbf3103669528 where one file was randomly placed inside another (breaking all CDRs) really disheartens me.

Comment by Samir Doshi [ 13/May/18 ]

Hi Rob,

That was unfortunate bug and I hope there will not be any other.

How would you like to keep your branch running?

On Sun 13 May, 2018, 4:33 AM Rob Thomas, <notifications@github.com> wrote:

> Closed ASTPPCOM-414 <https://github.com/iNextrix/ASTPP/pull/414>.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/iNextrix/ASTPP/pull/414#event-1623360854>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AA6gcZxovK3PWXnNq4brRfs8lMMvjx61ks5tx2otgaJpZM4TrLwM>
> .
>

Generated at Sat Feb 10 07:16:54 CET 2024 using Jira 8.13.3#813003-sha1:22ebedbb75c99b147c66f14e031dd8a2d214753a.