[#ASTPPCOM-264] Delete Search Record - This option deletes ALL termination rates

[ASTPPCOM-264] Delete Search Record - This option deletes ALL termination rates Created: 13/Nov/17 Updated: 27/Oct/19 Resolved: 28/Dec/17
Status:	Done
Project:	ASTPP Community
Component/s:	None
Affects Version/s:	None
Fix Version/s:	None

Type:

New Feature

Reporter:

slango-im

Assignee:

Samir Doshi

Resolution:

Done

Votes:

Labels:

bug_fixed

Remaining Estimate:

Not Specified

Time Spent:

Not Specified

Original Estimate:

Not Specified

Description

Using this option does not delete only the selected rates, it deletes all rates.

I am having this issue in all versions of Chrome and Firefox.

1) I search for "China", for example
2) 4 rates of of 12,300 appear
3) I delete search record
4) All 12,300 rates have been deleted

Comments

Comment by tridcatij [ 13/Nov/17 ]

I confirm. Removed all my rates as well.

Comment by plettonline [ 14/Nov/17 ]

Thanks for the heads up.. I first did a backup before testing.. I can
confirm that the same happens...
Clicking on delete search records deletes everything...

This however was on the Origination Rates..
I did note that it DID NOT delete the resellers Origination Rates

On Mon, Nov 13, 2017 at 10:04 PM, tridcatij <notifications@github.com>
wrote:

> I confirm. Removed all my rates as well.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/iNextrix/ASTPP/issues/264#issuecomment-344041085>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AQQbW2FQDAkf6sxFDORLmBQCujSLxggQks5s2KDqgaJpZM4QbzoT>
> .
>

Comment by slango-im [ 14/Nov/17 ]

Will it be possible to get a fix for this? It seems quite serious ...

Comment by Samir Doshi [ 15/Nov/17 ]

We are unable to reproduce the issue on exact way which you mentioned but we did below thing,

1. Searched in Origination rate with destination = "ind"
2. We got 2 records in search out of 10
3. Then we went to Termination rate (Opened in new tab), and clicked on Clear button of search.
4. Then we came back to Origination rate page and clicked "Delete Searched Records" and all (10 records) records got deleted.

To resolve this issue, we added condition to check where filter. If where filter, will not have search params then it will not execute delete query but it will just redirect back to list page.

Please update source code and test it out.

Comment by slango-im [ 15/Nov/17 ]

We don't toggle between the origination and termination rates. This bug is only for Termination Rates.

Simply, if I click "delete search record" on queried results on the "Termination Rates" page, it still deletes ALL termination rates.

It seems your fix does not work for us.

Comment by Samir Doshi [ 21/Nov/17 ]

Did you update source code and then checked? We have kept condition to to validate where criteria before executing delete query. So if somehow where criteria is blank, it will simply redirect the page but will not delete the records.

Moreover which version of OS and Browser are you using? We would like to try in same. Please provide information.

Comment by (Community) DN (Inactive) [ 28/Dec/17 ]

Closing this because of no activity since long time. Please respond to it to reopen it.

Generated at Sat Feb 10 07:15:37 CET 2024 using Jira 8.13.3#813003-sha1:22ebedbb75c99b147c66f14e031dd8a2d214753a.

[ASTPPCOM-264] Delete Search Record - This option deletes ALL termination rates Created: 13/Nov/17 Updated: 27/Oct/19 Resolved: 28/Dec/17