[ASTPPCOM-146] Issue 142 Created: 03/Nov/16  Updated: 01/Apr/21  Resolved: 01/Apr/21

Status: Done
Project: ASTPP Community
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: New Feature
Reporter: countrdd Assignee: Samir Doshi
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

Adding option to import termination rates using a column mapper



 Comments   
Comment by Samir Doshi [ 10/Nov/16 ]

[~countrdd] We have checked and found the issues. We have reported all the issues in,
https://github.com/iNextrix/ASTPP/issues/149

Comment by countrdd [ 16/Nov/16 ]

Updated.

Comment by dev-astpp [ 23/Nov/16 ]

[~countrdd] We have checked fixed issues and give update with new found issues. We have reported all the issues in,
ASTPPCOM-149

Comment by countrdd [ 23/Nov/16 ]

I must not be pusing this write, because it is fine on my systems….for all the erros you said.hmmmm

From: ASTPP Development notifications@github.com
Reply-To: iNextrix/ASTPP reply@reply.github.com
Date: Wednesday, November 23, 2016 at 7:46 AM
To: iNextrix/ASTPP ASTPP@noreply.github.com
Cc: Dustian Countryman countrdd@leillc.net, Mention mention@noreply.github.com
Subject: Re: [iNextrix/ASTPP] Issue 142 (ASTPPCOM-146)

@countrddhttps://github.com/countrdd We have checked fixed issues and give update with new found issues. We have reported all the issues in,
ASTPPCOM-149https://github.com/iNextrix/ASTPP/issues/149


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/iNextrix/ASTPP/pull/146#issuecomment-262504049, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADVysqF4BggIJ3MoV2zo8ZGhqWTNb07Tks5rBDW_gaJpZM4Kovls.

Comment by Samir Doshi [ 24/Nov/16 ]

@countrdd, I am sure it must be working perfect in your setup with proper data. While we are getting contribution from someone, that is our duty to verify the code and features with proper and improper data and once everything fine release it under the open source version. So that community not get buggy contributions and they can adopt new changes without hassle.

So far the feature which you have implemented will really be going to useful to all admins as they will no longer require to format the csvs to import the termination rates.

Comment by countrdd [ 25/Nov/16 ]

I agree, I should have been more clear, the format changes for the screen (i.e. html) looked like what you have pointed out, and I fixed that and for some reason I am cannot seem to push that up…

I am really looking forward to getting these in and figuring out what I am doing wrong with the pull request, that way I can contribute more.

Dusty

From: Samir Doshi <notifications@github.com>
Reply-To: iNextrix/ASTPP <reply@reply.github.com>
Date: Thursday, November 24, 2016 at 8:02 AM
To: iNextrix/ASTPP <ASTPP@noreply.github.com>
Cc: Dustian Countryman <countrdd@leillc.net>, Mention <mention@noreply.github.com>
Subject: Re: [iNextrix/ASTPP] Issue 142 (ASTPPCOM-146)

@countrdd<https://github.com/countrdd>, I am sure it must be working perfect in your setup with proper data. While we are getting contribution from someone, that is our duty to verify the code and features with proper and improper data and once everything fine release it under the open source version. So that community not get buggy contributions and they can adopt new changes without hassle.

So far the feature which you have implemented will really be going to useful to all admins as they will no longer require to format the csvs to import the termination rates.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://github.com/iNextrix/ASTPP/pull/146#issuecomment-262771581>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ADVysmJ8bounHCKASC-HsZcDuyDuKoWUks5rBYrygaJpZM4Kovls>.

Comment by countrdd [ 25/Nov/16 ]

See here is where it looks ok

From: Samir Doshi <notifications@github.com>
Reply-To: iNextrix/ASTPP <reply@reply.github.com>
Date: Thursday, November 24, 2016 at 8:02 AM
To: iNextrix/ASTPP <ASTPP@noreply.github.com>
Cc: Dustian Countryman <countrdd@leillc.net>, Mention <mention@noreply.github.com>
Subject: Re: [iNextrix/ASTPP] Issue 142 (ASTPPCOM-146)

@countrdd<https://github.com/countrdd>, I am sure it must be working perfect in your setup with proper data. While we are getting contribution from someone, that is our duty to verify the code and features with proper and improper data and once everything fine release it under the open source version. So that community not get buggy contributions and they can adopt new changes without hassle.

So far the feature which you have implemented will really be going to useful to all admins as they will no longer require to format the csvs to import the termination rates.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://github.com/iNextrix/ASTPP/pull/146#issuecomment-262771581>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ADVysmJ8bounHCKASC-HsZcDuyDuKoWUks5rBYrygaJpZM4Kovls>.

Comment by countrdd [ 19/Dec/16 ]

Sorry, Got busy. I think everything is there, just need to know if I need to do anything else.

Generated at Sat Feb 10 07:14:33 CET 2024 using Jira 8.13.3#813003-sha1:22ebedbb75c99b147c66f14e031dd8a2d214753a.